You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's an issue with the invocations of mocha --parallel in docker/test_js.sh which is used by the CI workflow. It seems that on some systems, this can fail silently.
To reproduce:
Checkout 325b89b (prior to the chalk fix) and rebuild a container for testing.
In the container, make this edit to a few lines in Makefile to speed up the example:
Modified: (The text here doesn't reflect this, but you need to use tabs, not spaces.)
test-js: test-prairielearn
test-prairielearn: start-support
@yarn mocha --parallel "tests/access.test.js" "tests/database.test.js"
echo finished with no error but should have failed
Run: docker/test_js.sh. On a 4-core CPU, this seems to succeed with no error (but it should have failed).
Now try again without --parallel. It should fail as expected.
Similarly, I note this behavior:
Using --parallel --jobs 2 has the problem (test succeeds when it should not).
Using --parallel --jobs 1 does not have the problem (test fails as expected).
Using --bail --parallel --jobs 2 does not have the problem (test fails as expected).
(Accordingly:) Using --bail --parallel (no jobs limit) does not have the problem (test fails as expected). Maybe this is an acceptable workaround for now?
This may be related to a bug with mocha's parallel mode that was previously reported: mochajs/mocha#4559
The text was updated successfully, but these errors were encountered:
The bug reported upstream appears to only affect ESM files that import from mocha, neither of which applies to us. It's possible that this is a similar but unrelated issue?
We haven't seen this issue occur again since this was opened. mochajs/mocha#4959 was opened to fix this upstream; I don't think there's anything else actionable for us to do at this point.
There's an issue with the invocations of
mocha --parallel
indocker/test_js.sh
which is used by the CI workflow. It seems that on some systems, this can fail silently.To reproduce:
Makefile
to speed up the example:Old:
Modified: (The text here doesn't reflect this, but you need to use tabs, not spaces.)
docker/test_js.sh
. On a 4-core CPU, this seems to succeed with no error (but it should have failed).--parallel
. It should fail as expected.Similarly, I note this behavior:
--parallel --jobs 2
has the problem (test succeeds when it should not).--parallel --jobs 1
does not have the problem (test fails as expected).--bail --parallel --jobs 2
does not have the problem (test fails as expected).--bail --parallel
(no jobs limit) does not have the problem (test fails as expected). Maybe this is an acceptable workaround for now?This may be related to a bug with mocha's parallel mode that was previously reported: mochajs/mocha#4559
The text was updated successfully, but these errors were encountered: