Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for parameters interfering with typing #4014

Closed
6 tasks done
PrzemyslawKlys opened this issue Jun 9, 2022 · 1 comment
Closed
6 tasks done

Suggestions for parameters interfering with typing #4014

PrzemyslawKlys opened this issue Jun 9, 2022 · 1 comment
Labels
Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed!

Comments

@PrzemyslawKlys
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

In some recent updates, you now get help from the engine with auto-complete. This is great as you no longer have to type CTRL+Space. While this is great for functions, parameters with validate sets and so on, it's pretty much destructive for typing standard strings.

It would be great if auto-fill for parameters where it's a string without autocomplete it would not suggest anything.

Showproblem

Of course workaround to it is - as soon as it shows up, press escape and continue typing. I can live with this if this is something not fixable.

PowerShell Version

PSVersion                      7.3.0-preview.4
PSEdition                      Core
GitCommitId                    7.3.0-preview.4
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

1.67.2
c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
x64

Extension Version

ms-vscode.powershell@2022.5.1
ms-vscode.powershell-preview@2022.5.5
tobysmith568.run-in-powershell@1.1.1
TylerLeonhardt.vscode-inline-values-powershell@0.0.6

Steps to Reproduce

Already did above.

Visuals

No response

Logs

No response

@PrzemyslawKlys PrzemyslawKlys added the Issue-Bug A bug to squash. label Jun 9, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jun 9, 2022
@PrzemyslawKlys PrzemyslawKlys changed the title Suggestions for parameters interefering with typing Suggestions for parameters interfering with typing Jun 9, 2022
@SeeminglyScience
Copy link
Collaborator

The accepting of the completion result is my bad, I forgot adding quote as a commit trigger would include at the start of a string literal. This is fixed with PowerShell/PowerShellEditorServices#1819

The greater issue of file completions in general not being useful most of the time is something that will take a hot minute to resolve, but I am working on it. First I must solve PowerShell/PowerShellEditorServices#1810, then I can exclude them when you aren't already typing a path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed!
Projects
None yet
Development

No branches or pull requests

2 participants