Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host needs updating for $psStyle #1645

Open
jhoneill opened this issue Dec 17, 2021 · 4 comments
Open

Host needs updating for $psStyle #1645

jhoneill opened this issue Dec 17, 2021 · 4 comments
Assignees

Comments

@jhoneill
Copy link

I filed an issue on the mail PowerShell project PowerShell/PowerShell#16643
Basically hosts other than "ConsoleHost" - including the Visual Studio Code Host need to be updated so that when $PSStyle.OutputRendering is set to plaintext Ansi colours are not sent to the terminal

image

Above you can see the green row labels in the PowerShell Integrated Console. Below you can see they're mono in the PWSH console.

image

What I'm being told over there is that fix goes with the host. hence creating this one.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Dec 17, 2021
@andyleejordan andyleejordan added Area-Extension Terminal Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Jan 5, 2022
@andyleejordan
Copy link
Member

Thanks for the bug report @jhoneill! We have a lot of work to do for the integrated console's host, especially with respect to the new PSStyle APIs.

@jhoneill
Copy link
Author

jhoneill commented Jan 6, 2022

@andschwa See also
PowerShell/PowerShell#16643
There's a discussion going on about whether this should be in host, and if it reasonable to drop this work onto you.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jan 6, 2022
@StevenBucher98 StevenBucher98 removed the Needs: Maintainer Attention Maintainer attention needed! label Jan 18, 2022
@JustinGrote
Copy link
Collaborator

JustinGrote commented Feb 21, 2022

FWIW the latest preview seems to work in both Host and Ansi mode, except for exceptions:
image
image

Detailmode kind of works but clearly has issues:
image

@andyleejordan
Copy link
Member

Sweet, looks like things are improving! Patrick had the idea of redirecting the host's PrivateData field to the underlying console host, and not that I know much about this but it seems to have made more host things work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants