You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_logger.LogError($"Top level runspace entered state '{oldRunspaceState.State}' for reason '{oldRunspaceState.Reason}' and was reinitialized."
+" Please report this issue in the PowerShell/vscode-PowerShell GitHub repository with these logs.");
UI.WriteErrorLine("The main runspace encountered an error and has been reinitialized. See the PowerShell extension logs for more details.");
}
else
{
_logger.LogError($"Current runspace entered state '{oldRunspaceState.State}' for reason '{oldRunspaceState.Reason}' and was popped.");
UI.WriteErrorLine($"The current runspace entered state '{oldRunspaceState.State}' for reason '{oldRunspaceState.Reason}'."
+" If this occurred when using Ctrl+C in a Windows PowerShell remoting session, this is expected behavior."
+" The session is now returning to the previous runspace.");
}
},
CancellationToken.None);
}
We need to induce a fault and see if this works as expected, as well as ensure it doesn't run at other times...
My suspicion is that it will need some refinement and could have some significant bugs in it. But it's currently a corner case and a worse-case scenario handler anyway (if it didn't exist, we are essentially crashed).
So we need to investigate this and see how we can improve:
detection of bad runspace state
restoration of good runspace state
how our threading mechanisms work in this scenario...
The text was updated successfully, but these errors were encountered:
We have a kind of primitive stab at a method to clean up a faulty runspace state in the PSES pipeline thread consumer here:
PowerShellEditorServices/src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Lines 784 to 826 in 9fd0dfa
We need to induce a fault and see if this works as expected, as well as ensure it doesn't run at other times...
My suspicion is that it will need some refinement and could have some significant bugs in it. But it's currently a corner case and a worse-case scenario handler anyway (if it didn't exist, we are essentially crashed).
So we need to investigate this and see how we can improve:
The text was updated successfully, but these errors were encountered: