Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline thread consumer task cancellation #1594

Open
rjmholt opened this issue Oct 26, 2021 · 0 comments
Open

Improve pipeline thread consumer task cancellation #1594

rjmholt opened this issue Oct 26, 2021 · 0 comments

Comments

@rjmholt
Copy link
Collaborator

rjmholt commented Oct 26, 2021

Because the pipeline thread consumer is single-threaded and runs tasks sequentially, there's the real possibility that a single bad task could starve it.

For now, Ctrl+C should cancel whatever task is running. This may indeed include background tasks...

But some ideas for improving this are:

  • A key-chord to cancel/unblock the pipeline thread when something other than console input is being run
  • A monitor thread to supervise the pipeline thread that:
    • Logs when tasks drag on
    • Alerts users to long running tasks
    • Allows cancellation
    • Can completely reset the main runspace...
@ghost ghost added the Needs: Triage Maintainer attention needed! label Oct 26, 2021
@StevenBucher98 StevenBucher98 added Area-Engine Area-Threading Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants