Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyBezier is not exported correct for ES Module. #196

Open
nathanwinder opened this issue Apr 2, 2023 · 3 comments · May be fixed by #215
Open

PolyBezier is not exported correct for ES Module. #196

nathanwinder opened this issue Apr 2, 2023 · 3 comments · May be fixed by #215
Labels
bug

Comments

@nathanwinder
Copy link

PolyBezier is not exported correctly for ES Modules:

import { Bezier, PolyBezier } from "bezier-js";

new Bezier(...);
new PolyBezier(...);
The requested module '/node_modules/.cache/.vite-storybook/deps/bezier-js.js?t=1680383587313&v=9ea929cc' 
does not provide an export named 'PolyBezier'

Workaround
PolyBezier is just a light wrapper around an array of Bezier , which imports correctly.
@Pomax
Copy link
Owner

Pomax commented Apr 4, 2023

cheers, looks like it's forgetting to re-export. Should be able to get this fixed and pushed out to npm tomorrow.

@Pomax Pomax added the bug label Apr 4, 2023
@artjuk
Copy link

artjuk commented May 19, 2023

cheers, looks like it's forgetting to re-export. Should be able to get this fixed and pushed out to npm tomorrow.

Writing as a reminder about this bug, I would appreciate that fix if you can.

@Pomax
Copy link
Owner

Pomax commented Jul 9, 2023

@artjuk I'm working on too many things to revisit this any time soon, unless you're interested in sponsoring the work, then I can bump it up to the next things I work on.

@GoodBoyNinja GoodBoyNinja linked a pull request Feb 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly export "PolyBezier" GoodBoyNinja/bezierjs
3 participants
@Pomax @nathanwinder @artjuk