Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noink doesn't disable ripple for first click #63

Open
blasten opened this issue Jan 28, 2016 · 4 comments
Open

noink doesn't disable ripple for first click #63

blasten opened this issue Jan 28, 2016 · 4 comments

Comments

@blasten
Copy link
Contributor

blasten commented Jan 28, 2016

Moved from PolymerElements/paper-slider#105

If I add the noink attribute, I still get a ripple effect for the first click, though I don't subsequent clicks (maybe - it seems like there is a situation where the ripple effect also occurs after the first one).

Any ideas?

Reproducible on:

  1. https://elements.polymer-project.org/elements/paper-checkbox?view=demo:demo/index.html&active=paper-checkbox

and

  1. https://elements.polymer-project.org/elements/paper-slider?view=demo:demo/index.html&active=paper-slider
@motss
Copy link

motss commented Jul 12, 2016

@notwaldorf
noink does create paper-ripple on demand when it is expecting to be not to create any ripple.
Is this a bug or an expected behavior that noink only hides the ripple effect but the paper-ripple will be created no matter what?

noink renders paper-ripple

@keanulee
Copy link
Contributor

It still creates a paper-ripple since a ripple will show on focus (even if noink is set, which only affects mouse/touch)

@motss
Copy link

motss commented Jul 12, 2016

@keanulee It makes sense. Thanks for pointing out.

@web-padawan
Copy link

@notwaldorf FYI: re-focusing browser tab causes ink to appear event if noink attribute is set.

Reproducible on https://elements.polymer-project.org/elements/paper-checkbox?view=demo:demo/index.html&active=paper-checkbox

Steps to reproduce:

  1. Toggle checkbox from second demo snippet (which has noink)
  2. Switch to other browser tab
  3. Go back to previous tab, you'll see the ripple around the checkbox.

Same for paper-toggle-button, paper-radio-button etc.

Is it by design? Shall I open another issue?

@notwaldorf notwaldorf removed their assignment Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants