Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-header-layout and min-height for flex items #552

Open
2 of 8 tasks
nicolasr75 opened this issue May 13, 2018 · 1 comment
Open
2 of 8 tasks

app-header-layout and min-height for flex items #552

nicolasr75 opened this issue May 13, 2018 · 1 comment

Comments

@nicolasr75
Copy link

nicolasr75 commented May 13, 2018

Description

I have a fullbleed app-header-layout which contains a tool bar and a body with flexible divs. The flexbox specification says that a flex item cannot be smaller than the size of its content along the main axis. To make flexible items work with 'overflow: scroll' one has to override min-height (for flexible column layouts) and set it to 0 instead of the default auto value. A thorough explanation can be found here:
https://stackoverflow.com/questions/36247140/why-dont-flex-items-shrink-past-content-size

The explanation there also talks about differences between f.e. Chrome and Firefox. For Firefox it may be necessary to set min-height: 0 also for ancestor flexible items. This is where app-header-layout comes into play.

If I set min-height: 0 in my content flex items the overflow:scroll works in Chrome but not in Firefox. The problem is the contentContainer in app-header-layout. If I use the developper tools in Firefox and add min-height:0 to the contentContainer during debugging, my layout works.

Is it somehow possible to make this work without having to change the source of app-header-layout myself (after every update of the Polymer sources)?

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@nicolasr75
Copy link
Author

I guess this is related to #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant