Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policyengine-core so that policyengine-us does not crash with fatal error #4516

Closed
martinholmer opened this issue May 10, 2024 · 0 comments · Fixed by #4526
Closed

Fix policyengine-core so that policyengine-us does not crash with fatal error #4516

martinholmer opened this issue May 10, 2024 · 0 comments · Fixed by #4526
Assignees
Labels
bug Something isn't working simulation

Comments

@martinholmer
Copy link
Collaborator

I am using the 0.770.0 version of policyengine-us and the 2.21.1 version of policyengine-core, which setup.py says is all that is required:

policyengine-us/setup.py

Lines 34 to 50 in 9c5ec52

install_requires=[
"click==8.1.3",
"h5py",
"microdf_python",
"pandas",
"pathlib",
"policyengine-core>=2.20.0,<3",
"pytest",
"pytest-dependency",
"pyyaml",
"requests",
"scipy==1.10.1",
"synthimpute",
"tables==3.8.0",
"tabulate",
"tqdm",
],

.

But yet when I run the MA and OH state income tests (see issue #993), they all fail with this error message:

File "//Users/mrh/anaconda3/envs/policyengine-us/lib/python3.10/site-packages/policyengine_core/simulations/simulation.py", line 535, in _calculate
    cache_path = self._get_macro_cache(variable_name, str(period))
File "//Users/mrh/anaconda3/envs/policyengine-us/lib/python3.10/site-packages/policyengine_core/simulations/simulation.py", line 1347, in _get_macro_cache
    self.dataset.file_path.parent
AttributeError: 'str' object has no attribute 'parent'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simulation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants