New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix New Jersey property tax credit income eligibility logic #4475
Comments
Thanks Martin. @hua7450 in the future could you please file a separate issue before adjusting an existing program? #4461 went beyond the scope indicated by the issue title and PR description (adding 2023 rules) by amending the property tax credit in 2021. Let's also add a legal code reference for the income limit when fixing this. @martinholmer, could you share why the lack of the NJ property tax credit income limit prior to #4461 didn't result in validation failures for 2021? Was it not in taxsim, or is it too niche a case to show up? If the latter could you add filers to the validation set that would be affected? |
I apologize, I will use more accurate descriptions for PRs in the future. |
@MaxGhenis asked in issue #4475:
I don't know. Are you really sure there was no income limit in the older code?
It has always been in TAXSIM35, which is why we used to not get property tax credit diffs.
The samples being used today are exactly the same as the samples we've been using over the past year or more. So, the cases in which this difference showed up after PR #4461 have always been in the samples.
This is not necessary because we have test failures in the standard samples (for example, property tax diffs in 134 cases in the |
I think this requires more digging, and a legal code reference. Here you can see the file at its previous snapshot. At first glance it's not obvious how these interact. Maybe @leogoldman remembers? |
I think you have it right, Max. The income limit applies in all cases to the NJ Property Tax Deduction (appropriate #4461 introduces an AGI check for these filers. From page 25 (pdf page 27) of the 2023 NJ-1040 instructions:
|
A number of bugs introduced in PR #4461 have caused a massive regression in NJ income tax testing results. Income eligibility for the NJ property tax credit is based on NJ gross income (not federal AGI as misspecified in PR #4461). Here are examples of the recently introduced bugs in the NJ income tax code:
policyengine-us/policyengine_us/variables/gov/states/nj/tax/income/credits/property_tax_credit/nj_property_tax_credit_eligible.py
Lines 40 to 42 in e3edf3f
policyengine-us/policyengine_us/parameters/gov/states/nj/tax/income/credits/property_tax/income_limit.yaml
Line 1 in e3edf3f
The text was updated successfully, but these errors were encountered: