Add comments for NY form IT-213 #4451
Conversation
|
Some concerns @PavelMakarchuk
|
|
@Shinuing thank you for looking into this, can we refactor the current code? I know it seems fairly complex but I believe we have missed a portion of the Worksheets |
I can model the worksheet (I don't think we model it at all). |
policyengine_us/parameters/gov/states/ny/tax/income/credits/ctc/amount/match.yaml
Show resolved
Hide resolved
; branch 'Shinuing/issue4427' of https://github.com/Shinuing/policyengine-us into Shinuing/issue4427
policyengine_us/parameters/gov/states/ny/tax/income/credits/ctc/amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
| ] | ||
| # Line 6 | ||
| federal_round_amount = max_( | ||
| math.ceil(total - federal_threshold / p.amount.base) |
There was a problem hiding this comment.
can you separate this into multiple steps for clarity?
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
| return where( | ||
| multi_children_family, | ||
| min_(adjusted_amount, adjusted_multi_children_amount), | ||
| min_(adjusted_amount, adjusted_earned_income_match), |
There was a problem hiding this comment.
make the min statements its own vars in this formula
| period: year | ||
| label: NY CTC additional tax credit children amount | ||
| reference: | ||
| - title: Instructions for Form IT-213 Claim for Empire State Child Credit |
There was a problem hiding this comment.
could you add 2021, 2022 , and 2023 tax forms as well as the legal code here?
There was a problem hiding this comment.
could you add 2021, 2022 , and 2023 tax forms as well as the legal code here?
cannot find any limit in the legal code
There was a problem hiding this comment.
Also, starting from 2023, no more min age limitation. And no worksheet B anymore. in this case we may need to create new calculations, please advice
...engine_us/parameters/gov/states/ny/tax/income/credits/ctc/additional_number_of_children.yaml
Outdated
Show resolved
Hide resolved
| "education_tax_credits", | ||
| # d Form 1040, Schedule 3, line 4, Retirement savings contributions credit | ||
| "savers_credit", | ||
| # e Form 1040, Schedule 3, line 6l, Total increase/decrease to reporting year tax |
There was a problem hiding this comment.
@PavelMakarchuk do we have any variables here?
| foreign_tax_credit_eligible = ( | ||
| tax_unit("foreign_tax_credit", period) > 0 | ||
| ) | ||
| # line11_amount = where(foreign_tax_credit_eligible, selected_credit_amount, ) |
There was a problem hiding this comment.
@PavelMakarchuk do we need to include all info here https://www.tax.ny.gov/pdf/2021/inc/it213i_2021.pdf#page=4
line 11 for worksheet b
There was a problem hiding this comment.
same for worksheet C 4a
try to fix #4427