Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some shiny variants #76

Open
elpekenin opened this issue Sep 10, 2022 · 4 comments
Open

Missing some shiny variants #76

elpekenin opened this issue Sep 10, 2022 · 4 comments

Comments

@elpekenin
Copy link

elpekenin commented Sep 10, 2022

I've been working on a little script to make normal+shiny images, and found some missing assets.
Here is the source for it (just in case someone wants to use it):

import os
from os import path
from PIL import Image, ImageDraw


# NOTE: File is located at `sprites`, will break on other locations due to relative paths
# Read mask image
MASK   = Image.open("mask.png").convert("1") # 96x96 mask whichs splits the image in half with a diagonal cut
INPUT  = path.join(".", "pokemon")
OUTPUT = path.join(INPUT, "edited")

# Create directory if needed
if not path.exists(OUTPUT):
    os.mkdir(OUTPUT)

# Iterate all images(pokemons)
for i in os.listdir(INPUT):
    # Dodge directories
    if "." not in i:
        continue
    
    # Some pokes don't have a shiny sprite on the directory, need to handle the exception
    try:
        sprite_path = path.join(INPUT, i)
        shiny_path  = sprite_path.replace("pokemon", "pokemon/shiny")

        sprite = Image.open(sprite_path).convert("RGBA")
        shiny  = Image.open(shiny_path ).convert("RGBA")

        output = Image.composite(sprite, shiny, MASK)
        
        # Empty line on the intersection, looks fancier imo
        draw = ImageDraw.Draw(output)
        draw.line((0, 0) + output.size, width=1, fill=(0, 0, 0, 0))

        output.save(path.join(OUTPUT, i))

    except:
        print(f"{i.split('.')[0]}")

And the list of missing files

775-form-1
382-primal
384-mega
10094
676-kabuki
260-mega
10031
10018
10010
773-grass
214-mega
6-mega-y
319-mega
671-yellow
10003
10030
10075
380-mega
323-mega
354-mega
666-modern
257-mega
666-continental
10008
773-ice
710-super
10097
208-mega
150-mega-y
773-ghost
10150
10019
773-dark
65-mega
10093
666-ocean
711-large
10032
115-mega
18-mega
10009
773-normal
248-mega
666-poke-ball
150-mega-x
10011
10149
306-mega
10226
10227
383-primal
670-orange
3-mega
720-unbound
10043
710-large
10012
10017
666-fancy
676-heart
10190
10028
676-star
414-plant
10135
10132
substitute
10029
710-small
142-mega
669-white
773-dragon
359-mega
773-electric
671-white
10044
669-orange
303-mega
10024
334-mega
666-marine
10027
10134
130-mega
10005
676-debutante
773-bug
308-mega
666-jungle
773-fire
741-baile
676-pharaoh
10121
671-orange
10099
773-ground
666-monsoon
10021
10117
10020
229-mega
666-tundra
773-rock
381-mega
666-garden
716-neutral
773-psychic
666-polar
362-mega
10035
773-poison
10144
10216
773-water
711-small
10145
15-mega
774-red-meteor
778-disguised
666-archipelago
666-icy-snow
676-la-reine
670-blue
10007
9-mega
10006
373-mega
784-totem
773-steel
676-dandy
10002
10022
10151
212-mega
746-solo
302-mega
460-mega
666-elegant
310-mega
666-high-plains
10217
10131
376-mega
127-mega
428-mega
669-yellow
10095
666-sandstorm
670-white
10023
10096
531-mega
448-mega
665-icy-snow
94-mega
10122
773-fighting
666-river
475-mega
666-sun
10001
664-icy-snow
711-super
10098
773-flying
869-gmax
80-mega
719-mega
10148
6-mega-x
666-savanna
669-blue
670-yellow
10016
254-mega
773-fairy
445-mega
10025
181-mega
10068
10130
676-matron
671-blue
10004
10186
10133
745-midday
676-diamond
282-mega

Also worth noting: 804s.png is the same as shiny/804.png and can likely be deleted

@devmike123
Copy link
Collaborator

Thanks you for informing! We'll work on them asap!

@Naramsim
Copy link
Member

Hi, yes sure, but this isn't a PR. And I'm merging all PRs now. Should I wait till October?

@Naramsim
Copy link
Member

Still 3 days to Octoberfest

@devmike123
Copy link
Collaborator

Still 3 days to Octoberfest

I have arranged 50+ missing sprites. So I will make prs and contribute them one by one and can therefore also participate in the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants