Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing on passive tree generation #570

Open
DanajZ opened this issue Oct 24, 2021 · 2 comments
Open

Crashing on passive tree generation #570

DanajZ opened this issue Oct 24, 2021 · 2 comments

Comments

@DanajZ
Copy link

DanajZ commented Oct 24, 2021

Under certain conditions I am getting an exception when attempting to generate a skill tree. I'll attach a stack trace and the build

   at PoESkillTree.TreeGenerator.Algorithm.Model.GraphNode..ctor(IEnumerable`1 nodes) in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Algorithm\Model\GraphNode.cs:line 62
   at PoESkillTree.TreeGenerator.Algorithm.Model.SearchGraph.SetStartNodes(IReadOnlyCollection`1 startNodes) in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Algorithm\Model\SearchGraph.cs:line 41
   at PoESkillTree.TreeGenerator.Solver.AbstractSolver`1.CreateStartNodes(SearchGraph searchGraph) in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Solver\AbstractSolver.cs:line 202
   at PoESkillTree.TreeGenerator.Solver.AbstractSolver`1.BuildSearchGraph() in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Solver\AbstractSolver.cs:line 182
   at PoESkillTree.TreeGenerator.Solver.AbstractSolver`1.Initialize() in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Solver\AbstractSolver.cs:line 107
   at PoESkillTree.TreeGenerator.Solver.AbstractGeneticSolver`1.Initialize() in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\Solver\AbstractGeneticSolver.cs:line 79
   at PoESkillTree.TreeGenerator.ViewModels.ControllerViewModel.<InitializeAsync>b__56_0() in C:\Users\Danaj\Source\Repos\PoESkillTree\WPFSKillTree\TreeGenerator\ViewModels\ControllerViewModel.cs:line 219
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
<?xml version="1.0" encoding="utf-8"?>
<PoEBuild xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <Name>New build</Name>
  <Realm>PC</Realm>
  <Level>1</Level>
  <Url>https://www.pathofexile.com/passive-skill-tree/AAAABgIAAAAA</Url>
  <LastUpdated>2021-10-24T04:07:03.8901791-04:00</LastUpdated>
  <CustomGroups />
  <Bandits>
    <Choice>None</Choice>
  </Bandits>
  <CheckedNodeIds>
    <unsignedShort>31359</unsignedShort>
    <unsignedShort>9535</unsignedShort>
    <unsignedShort>44988</unsignedShort>
    <unsignedShort>7263</unsignedShort>
    <unsignedShort>16236</unsignedShort>
    <unsignedShort>15290</unsignedShort>
    <unsignedShort>544</unsignedShort>
    <unsignedShort>61039</unsignedShort>
    <unsignedShort>1325</unsignedShort>
    <unsignedShort>48438</unsignedShort>
    <unsignedShort>15344</unsignedShort>
    <unsignedShort>11239</unsignedShort>
    <unsignedShort>3309</unsignedShort>
    <unsignedShort>39821</unsignedShort>
    <unsignedShort>60803</unsignedShort>
    <unsignedShort>6542</unsignedShort>
    <unsignedShort>94</unsignedShort>
    <unsignedShort>19858</unsignedShort>
    <unsignedShort>9206</unsignedShort>
    <unsignedShort>36221</unsignedShort>
    <unsignedShort>24133</unsignedShort>
    <unsignedShort>53114</unsignedShort>
    <unsignedShort>65210</unsignedShort>
    <unsignedShort>48099</unsignedShort>
    <unsignedShort>32117</unsignedShort>
    <unsignedShort>19069</unsignedShort>
    <unsignedShort>34678</unsignedShort>
    <unsignedShort>26528</unsignedShort>
    <unsignedShort>58271</unsignedShort>
    <unsignedShort>40743</unsignedShort>
    <unsignedShort>64241</unsignedShort>
    <unsignedShort>55307</unsignedShort>
    <unsignedShort>15837</unsignedShort>
    <unsignedShort>26471</unsignedShort>
    <unsignedShort>51881</unsignedShort>
  </CheckedNodeIds>
  <CrossedNodeIds />
  <ConfigurationStats />
  <AdditionalData>{
  "TreeGenerator": {
    "SelectedTabIndex": 0,
    "SteinerTab": {
      "ExcludeCrossed": true
    },
    "AdvancedTab": {
      "AdditionalPoints": 22,
      "Iterations": 3,
      "IncludeChecked": true,
      "ExcludeCrossed": true,
      "TreePlusItemsMode": false,
      "WeaponClass": 12,
      "OffHand": 1,
      "Tags": 0,
      "AttributeConstraints": [],
      "PseudoAttributeConstraints": []
    },
    "AutomatedTab": {}
  }
}</AdditionalData>
  <Version>1.0</Version>
</PoEBuild>

image

@EmmittJ
Copy link
Member

EmmittJ commented Oct 25, 2021

Ok, so I fixed an issue with loading skill trees (I think that might be the problem here). Basically, when you switch to a blank tree the root node wasn't being allocated. There appears to be a different issue with the advanced generator skipping nodes. The normal "Tagged Nodes" generator is working fine

@DanajZ
Copy link
Author

DanajZ commented Oct 26, 2021

It didn't seem to fix this particular issue. Interestingly enough I was able to run it after I reset and then rebuilt the checked nodes. Below I have included two trees. The 'Works Fine' tree worked initially but when I added a new skill choice it seemed to crash after I tried to generate the tree again.

I think it may also have to do with the undo feature potentially? I was able to run the generator after resetting the tree but it broke when I did the following:

  1. Load the 'Works Fine' Build
  2. Use Run 'tagged nodes' generator
  3. Tree will build fine
  4. Press ctrl + Z to undo the tree
  5. Allocate the skill 'Toxic Strikes' (This is also the 'Exception' build below)
  6. Use Run 'tagged nodes' generator
  7. Exception occurs

Either way you're probably right; it has nothing to with the node from what I've tested I can allocate and generate the tree fine with any of these nodes, it's probably a very specific set of actions that is causing the issue.

Thanks for all your hard work!

Works Fine:

<?xml version="1.0" encoding="utf-8"?>
<PoEBuild xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <Name>New build</Name>
  <Realm>PC</Realm>
  <Level>1</Level>
  <Url>https://www.pathofexile.com/passive-skill-tree/AAAABgIAAAAA</Url>
  <LastUpdated>2021-10-26T19:33:13.8831482-04:00</LastUpdated>
  <CustomGroups />
  <Bandits>
    <Choice>None</Choice>
  </Bandits>
  <CheckedNodeIds>
    <unsignedShort>31359</unsignedShort>
    <unsignedShort>9535</unsignedShort>
    <unsignedShort>44988</unsignedShort>
    <unsignedShort>7263</unsignedShort>
    <unsignedShort>15290</unsignedShort>
    <unsignedShort>544</unsignedShort>
    <unsignedShort>61039</unsignedShort>
    <unsignedShort>1325</unsignedShort>
    <unsignedShort>48438</unsignedShort>
    <unsignedShort>15344</unsignedShort>
    <unsignedShort>11239</unsignedShort>
    <unsignedShort>3309</unsignedShort>
    <unsignedShort>39821</unsignedShort>
    <unsignedShort>60803</unsignedShort>
    <unsignedShort>6542</unsignedShort>
    <unsignedShort>94</unsignedShort>
    <unsignedShort>19858</unsignedShort>
    <unsignedShort>9206</unsignedShort>
    <unsignedShort>36221</unsignedShort>
    <unsignedShort>24133</unsignedShort>
    <unsignedShort>53114</unsignedShort>
    <unsignedShort>65210</unsignedShort>
    <unsignedShort>48099</unsignedShort>
    <unsignedShort>32117</unsignedShort>
    <unsignedShort>19069</unsignedShort>
    <unsignedShort>34678</unsignedShort>
    <unsignedShort>26528</unsignedShort>
    <unsignedShort>58271</unsignedShort>
    <unsignedShort>40743</unsignedShort>
    <unsignedShort>64241</unsignedShort>
    <unsignedShort>55307</unsignedShort>
    <unsignedShort>15837</unsignedShort>
    <unsignedShort>26471</unsignedShort>
    <unsignedShort>51881</unsignedShort>
  </CheckedNodeIds>
  <CrossedNodeIds />
  <ConfigurationStats />
  <AdditionalData>{
  "TreeGenerator": {
    "SelectedTabIndex": 0,
    "SteinerTab": {
      "ExcludeCrossed": true
    },
    "AdvancedTab": {
      "AdditionalPoints": 22,
      "Iterations": 3,
      "IncludeChecked": true,
      "ExcludeCrossed": true,
      "TreePlusItemsMode": false,
      "WeaponClass": 12,
      "OffHand": 1,
      "Tags": 0,
      "AttributeConstraints": [],
      "PseudoAttributeConstraints": []
    },
    "AutomatedTab": {}
  }
}</AdditionalData>
  <Version>1.0</Version>
</PoEBuild>

Exception:


<?xml version="1.0" encoding="utf-8"?>
<PoEBuild xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <Name>New build</Name>
  <Realm>PC</Realm>
  <Level>1</Level>
  <Url>https://www.pathofexile.com/passive-skill-tree/AAAABgIAAAAA</Url>
  <LastUpdated>2021-10-26T19:36:41.0538438-04:00</LastUpdated>
  <CustomGroups />
  <Bandits>
    <Choice>None</Choice>
  </Bandits>
  <CheckedNodeIds>
    <unsignedShort>31359</unsignedShort>
    <unsignedShort>9535</unsignedShort>
    <unsignedShort>44988</unsignedShort>
    <unsignedShort>7263</unsignedShort>
    <unsignedShort>15290</unsignedShort>
    <unsignedShort>544</unsignedShort>
    <unsignedShort>61039</unsignedShort>
    <unsignedShort>1325</unsignedShort>
    <unsignedShort>48438</unsignedShort>
    <unsignedShort>15344</unsignedShort>
    <unsignedShort>11239</unsignedShort>
    <unsignedShort>3309</unsignedShort>
    <unsignedShort>39821</unsignedShort>
    <unsignedShort>60803</unsignedShort>
    <unsignedShort>6542</unsignedShort>
    <unsignedShort>94</unsignedShort>
    <unsignedShort>19858</unsignedShort>
    <unsignedShort>9206</unsignedShort>
    <unsignedShort>36221</unsignedShort>
    <unsignedShort>24133</unsignedShort>
    <unsignedShort>53114</unsignedShort>
    <unsignedShort>65210</unsignedShort>
    <unsignedShort>48099</unsignedShort>
    <unsignedShort>32117</unsignedShort>
    <unsignedShort>19069</unsignedShort>
    <unsignedShort>34678</unsignedShort>
    <unsignedShort>26528</unsignedShort>
    <unsignedShort>58271</unsignedShort>
    <unsignedShort>40743</unsignedShort>
    <unsignedShort>64241</unsignedShort>
    <unsignedShort>55307</unsignedShort>
    <unsignedShort>15837</unsignedShort>
    <unsignedShort>26471</unsignedShort>
    <unsignedShort>51881</unsignedShort>
    <unsignedShort>16236</unsignedShort>
  </CheckedNodeIds>
  <CrossedNodeIds />
  <ConfigurationStats />
  <AdditionalData>{
  "TreeGenerator": {
    "SelectedTabIndex": 0,
    "SteinerTab": {
      "ExcludeCrossed": true
    },
    "AdvancedTab": {
      "AdditionalPoints": 22,
      "Iterations": 3,
      "IncludeChecked": true,
      "ExcludeCrossed": true,
      "TreePlusItemsMode": false,
      "WeaponClass": 12,
      "OffHand": 1,
      "Tags": 0,
      "AttributeConstraints": [],
      "PseudoAttributeConstraints": []
    },
    "AutomatedTab": {}
  }
}</AdditionalData>
  <Version>1.0</Version>
</PoEBuild>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants