Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affix crafting information from the GGPK #465

Closed
brather1ng opened this issue May 1, 2017 · 0 comments · Fixed by #466
Closed

Affix crafting information from the GGPK #465

brather1ng opened this issue May 1, 2017 · 0 comments · Fixed by #466

Comments

@brather1ng
Copy link
Member

brather1ng commented May 1, 2017

Our current Affix information is from exilemods.com. Biggest issue with that is that it's outdated, so I want to get the information directly from the GGPK (through the files I already exported in RePoE).

Since the GGPK's mod information is based on tags, I'll take the opportunity to replace our ItemGroup and ItemType enums by GGPK based information with ItemClass (based on ItemClasses.dat) and Tags (based on Tags.dat). This will hopefully make a lot of conversions between enums and other enums or game information much easier (e.g. it already made the ItemBaseLoader 1/3 shorter). And it should be helpful later on for the computation rewriting.

This is the last thing I want to do before starting with #463, so I thought I'd let you know.

Edit: I'll also switch over to translating mod/stat ids on-the-fly while crafting instead of using pre-translated strings. I'll need to implement translation anyway and this'll fix items with changing translations depending on the value, like Ventor's Gamble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant