Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal_error always shows error / backtrace, no matter how show_php_errors_on_frontend / show_php_errors are set #2148

Open
uvok opened this issue Apr 15, 2024 · 0 comments

Comments

@uvok
Copy link

uvok commented Apr 15, 2024

When a fatal error occurs (function fatal_error), Piwigo will apparently always display an error page with an error message and a backtrace.
(The php configuration options display_errors and) the local config options show_php_errors_on_frontend / show_php_errors seem to be ignored in this case.

This is apparently because the function signature is function fatal_error($msg, $title=null, $show_trace=true), and all (?) callers only pass the first argument.

This could be a security concern (I guess?), a lot of web hosting guides recommend to switch off displaying PHP errors on the frontend. I would prefer to just have a generic "Internal Server Error" be displayed (especially with the config options set as they are).

I encountered this when I set up a separate PHP pool, running it as a separate user, after I already set up Piwigo. As a result, the _data directory contents were not writable, and Piwigo was complaining about this.

Piwigo version: 14.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant