Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not uninstall VSIX - looking for LICENSE.txt #301

Open
clairernovotny opened this issue Jul 29, 2017 · 5 comments
Open

Could not uninstall VSIX - looking for LICENSE.txt #301

clairernovotny opened this issue Jul 29, 2017 · 5 comments
Labels
bug
Projects
VisualRust Packaging/Building
Milestone
0.2

Comments

@clairernovotny
Copy link

Trying to uninstall the latest VSIX, the VSIX Installer crashed with an error about a missing file:
C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\PREVIEW\ENTERPRISE\COMMON7\IDE\LICENSE.txt

If I add that file manually, it will uninstall. Seems like the VSIX has a relative path somewhere instead of an absolute one? Not sure why it'd be looking for a file in that directory otherwise.
@Boddlnagg
Copy link
Contributor

Just to clarify: which "latest" VSIX do you refer to? The one released on the market place? Or the latest AppVeyor build?

@clairernovotny
Copy link
Author

The latest AppVeyor build from this project (VS 2017).

@clairernovotny
Copy link
Author

I'm betting this is the issue: https://github.com/PistonDevelopers/VisualRust/blob/master/src/VisualRust/source.extension.release.2017.vsixmanifest#L7

@MaulingMonkey
Copy link
Collaborator

There are some inconsistencies in the .vsixmanifest <License> paths:

source.extension.debug.vsixmanifest: LICENSE.txt
source.extension.release.2015.vsixmanifest: ..\..\LICENSE.txt
source.extension.release.2017.vsixmanifest: ..\..\LICENSE.txt

@MaulingMonkey
Copy link
Collaborator

Eyeballing the existing .vsix es, it looks like LICENSE.txt is the correct path. I'll roll a fix into my PR.

MaulingMonkey added a commit to MaulingMonkey/VisualRust that referenced this issue Jul 29, 2017
@MaulingMonkey
Fix vsix paths to LICENSE.txt.
0239104 
.debug.vsixmanifest already referenced LICENSE.txt

Ref: PistonDevelopers#301
    "Could not uninstall VSIX - looking for LICENSE.txt"
@MaulingMonkey MaulingMonkey added this to the 0.2 milestone Sep 20, 2017
@MaulingMonkey MaulingMonkey self-assigned this Sep 20, 2017
@MaulingMonkey MaulingMonkey mentioned this issue Oct 14, 2017
Open
@MaulingMonkey MaulingMonkey removed their assignment Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
VisualRust Packaging/Building
Awaiting triage
Milestone
0.2
Development

No branches or pull requests
3 participants
@MaulingMonkey @Boddlnagg @clairernovotny