Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Bar Time is Not Show and Popup is Cut #1090

Open
yingjinWong opened this issue Dec 5, 2023 · 12 comments
Open

Bottom Bar Time is Not Show and Popup is Cut #1090

yingjinWong opened this issue Dec 5, 2023 · 12 comments
Labels

Comments

@yingjinWong
Copy link

dialog is cut

  1. First issue
    When config player view with layout_marginHorizontal 20 dp, the dialog is cut and not showed fully. How to handle this issue?
    why dialog can not be adjusted itself to make sure show completely?

        <com.pierfrancescosoffritti.androidyoutubeplayer.core.player.views.YouTubePlayerView
         android:layout_width="0dp"
         android:layout_height="@dimen/adapt_y188"
         android:layout_marginHorizontal="20dp"
         app:autoPlay="false"
         app:enableAutomaticInitialization="false"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
         app:layout_constraintTop_toBottomOf="@id/item_magazine_section_img_caption"
         app:layout_goneMarginTop="@dimen/adapt_y8"/>
    
  2. Second issue
    Time and duration can not be show except full screen with landscape. How to make sure time and duration showed in portrait orientation and keep youtube controller icon (click to show dialog in first issue)at the same time.

time and duration not showed

Please help me out, thanks.

@PierfrancescoSoffritti
Copy link
Owner

I don't think the sample app has these problems? I think your player is too small. The library does not control the UI rendered in the player.

@yingjinWong
Copy link
Author

the player width and height is not big enough to ensure to show those elements. is it possible to show those element when player is not in full screen, which is designer requirement?

@yingjinWong
Copy link
Author

Like make font size smaller or icon smaller, or hide text after mute icon. Can you give some tips where can i adjust it?

@billdizl
Copy link

billdizl commented Dec 5, 2023

text

Like make font size smaller or icon smaller, or hide text after mute icon. Can you give some tips where can i adjust it?

小伙子,@PierfrancescoSoffritti 说了,他说他不认为这个库有问题,因为这个库不控制UI.我给你一个建议是 自定义实现UI,可以参考库的demo,加油小伙子

@yingjinWong
Copy link
Author

@billdizl 谢谢你的提议,custom ui 的可以保留youtube icon 么?我看了demo没有这个属性view配置。但是我不是小伙子啊🤣

@billdizl
Copy link

billdizl commented Dec 5, 2023

@billdizl 谢谢你的提议,custom ui 的可以保留youtube icon 么?我看了demo没有这个属性view配置。但是我不是小伙子啊🤣

可以,我都已经实现了 ,只是我实现的比较简单而已,主要我是用在recyclyview列表播放的,类似中国的淘宝,京东,今日头条列表播放视频的

@billdizl
Copy link

billdizl commented Dec 5, 2023

注意下 这个youtube lib库存在内存泄漏问题,非常严重

@billdizl
Copy link

billdizl commented Dec 5, 2023

但是经过本宝的修改已经修复了这个问题,目前在我的项目中运行良好

@yingjinWong
Copy link
Author

@billdizl 谢谢你的提议,custom ui 的可以保留youtube icon 么?我看了demo没有这个属性view配置。但是我不是小伙子啊🤣

可以,我都已经实现了 ,只是我实现的比较简单而已,主要我是用在recyclyview列表播放的,类似中国的淘宝,京东,今日头条列表播放视频的

可以上传demo file 参考下么?谢谢

@billdizl
Copy link

billdizl commented Dec 5, 2023

谢谢

仓库中已经有demo 可以参考 只是不全,样式很丑,需要自己改,其实这个仓库就是个webview加载的youtube链接,通过js调用来实现的,有时间可以研究下

@PierfrancescoSoffritti
Copy link
Owner

I don't speak Chinese, can this issue be closed?

@billdizl
Copy link

billdizl commented Dec 7, 2023

@yingjinWong 解决了吗,解决了 就可以关闭此问题了~~~嗷嗷叫~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants