Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging dependency exclusions should be handled using markers #14

Open
techalchemy opened this issue Apr 4, 2019 · 0 comments
Open

Comments

@techalchemy
Copy link

Greetings! I was preparing to do some work on this package when I noticed an issue in the definition of some of the packaging dependencies. In order to accommodate modern python packaging practices, python-version specific dependencies should be handled using the markers syntax rather than executing a conditional version check at runtime. This allows for tools (like PyPI's new JSON endpoints) to identify all of the dependencies even if they are not themselves running the relevant python versions.

_python2_requires = [
    'future',  # For backport of surrogateescape
] if sys.version_info < (3,) else []

Becomes

setup(
    ...
    install_requires=[
        "future;python_version<3.0"
    ],
)
techalchemy added a commit to techalchemy/backports.os that referenced this issue Apr 4, 2019
- Fixes PiDelport#14

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant