Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solver] couplings input should be a dict or matrix #45

Open
Phionx opened this issue Dec 6, 2021 · 0 comments
Open

[solver] couplings input should be a dict or matrix #45

Phionx opened this issue Dec 6, 2021 · 0 comments
Labels
core Core features/analysis/bugs/etc.

Comments

@Phionx
Copy link
Owner

Phionx commented Dec 6, 2021

The couplings input may be better represented by a dict with the following:

  • key (Tuple[int]): (i,j) coupling between node i and j
  • value (float): coupling strength
    We may also want to accept a full coupling matrix.

However, this would require a rewrite of both code and many demo notebooks...

@Phionx Phionx added the core Core features/analysis/bugs/etc. label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core features/analysis/bugs/etc.
Projects
None yet
Development

No branches or pull requests

1 participant