Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make telemetry files path configurable without enabling debug mode #6

Merged
merged 11 commits into from May 23, 2024
Merged

Make telemetry files path configurable without enabling debug mode #6

merged 11 commits into from May 23, 2024
+60 −34

Conversation

artemgavrilov
Copy link
Collaborator

@artemgavrilov artemgavrilov commented May 9, 2024 •
edited

Resolves: #5

@artemgavrilov artemgavrilov marked this pull request as ready for review May 9, 2024 16:30
codeforall
codeforall approved these changes May 15, 2024
View reviewed changes
Copy link

@codeforall codeforall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Naeem-Akhter
Naeem-Akhter approved these changes May 23, 2024
View reviewed changes
Copy link

@Naeem-Akhter Naeem-Akhter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemgavrilov artemgavrilov merged commit 04043fb into main May 23, 2024
5 checks passed
@artemgavrilov artemgavrilov deleted the configurable-path branch May 23, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeforall codeforall codeforall approved these changes

@dAdAbird dAdAbird dAdAbird approved these changes

@Naeem-Akhter Naeem-Akhter Naeem-Akhter approved these changes

@dutow dutow Awaiting requested review from dutow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make telemetry files path configurable without DEBUG mode
4 participants
@artemgavrilov @codeforall @dAdAbird @Naeem-Akhter