Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pod meta fields to the CR #59

Open
voltbit opened this issue Jan 20, 2021 · 0 comments
Open

Add the pod meta fields to the CR #59

voltbit opened this issue Jan 20, 2021 · 0 comments
Labels
breaking-change Changes in the CR schema or major functionality difference enhancement New feature or request

Comments

@voltbit
Copy link
Contributor

voltbit commented Jan 20, 2021

Currently we can only trigger a rolling update/restart of the pods by changing the configuration of the container images or resources:

https://github.com/PayU/redis-operator/blob/master/controllers/rediscluster.go#L643-L654

However, the RedisCluster CR and the controller acts as a Deployment resource - they define and manage the pods directly. We could improve the support of pod rolling restart by adding a pod template inside the CR that will contain both the pod meta and pod spec and track changes of this template configuration.
This would allow triggering of rolling update on any pod change, including annotations and labels.

An alternative solution is to encapsulate each pod in a Deployment or StatefulSet and keep their pod template as field in the CR.

@voltbit voltbit changed the title Improve the rolling update functionality Add the pod meta fields to the CR Feb 19, 2021
@voltbit voltbit added enhancement New feature or request breaking-change Changes in the CR schema or major functionality difference labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes in the CR schema or major functionality difference enhancement New feature or request
Development

No branches or pull requests

1 participant