Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of OpenAPI 3 known issues #122

Open
tamlyn opened this issue Apr 28, 2020 · 3 comments
Open

Clarification of OpenAPI 3 known issues #122

tamlyn opened this issue Apr 28, 2020 · 3 comments

Comments

@tamlyn
Copy link

tamlyn commented Apr 28, 2020

The discriminator support in the inheritance chain stops when getting to a child without a discriminator (a leaf in the inheritance tree), meaning a child without a discriminator cannot point to another child with a discriminator.

Is the implication of this that the provided discriminator-on-child example will not work under OpenAPI 3?

@kobik
Copy link
Collaborator

kobik commented Apr 30, 2020

@tamlyn yes, i believe so.

it's a limitation of api-shcema-builder we rely on when parsing definitions file and should be addressed there.

@tamlyn
Copy link
Author

tamlyn commented May 4, 2020

Thanks. I didn't understand what that meant until I came across the problem myself. It's annoying to discover this limitation only after investing several days of effort into it.

I'm going to leave this open a bit longer in the hope that it will encourage me to submit a PR that clarifies the wording.

@kobik
Copy link
Collaborator

kobik commented May 15, 2020

@tamlyn, now you made me waiting for your PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants