Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when having a nil attributedTitle #18

Open
dusek opened this issue Sep 6, 2016 · 1 comment
Open

Crash when having a nil attributedTitle #18

dusek opened this issue Sep 6, 2016 · 1 comment

Comments

@dusek
Copy link

dusek commented Sep 6, 2016

Hi,

after I upgraded from 6866d4d to ff72143, my app started crashing. I discovered that it is due to me setting attributedTitle of the startDownloadButton to nil, and this code thus initializing an NSAttributedString with a nil string.

I think the solution is quite easy - in [PKDownloadButton updateButton:title:], check if the passed title is nil. If yes, initialize attrTitle itself as nil.

@ryanholden8
Copy link
Contributor

ryanholden8 commented Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants