Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript compability #10

Open
volbrene opened this issue Jan 14, 2020 · 13 comments
Open

Typescript compability #10

volbrene opened this issue Jan 14, 2020 · 13 comments

Comments

@volbrene
Copy link

Hello, nice project! Is is possible to add typescript compability for this project?

@PatrickJS
Copy link
Owner

yeah I can add that

@dwelch2344
Copy link

Any word on this? Happy to contribute if needed

@nmaves
Copy link

nmaves commented Jun 23, 2022

At this point, I think we would have to contribute to making this happen. Which I am fine with. But is this project even active anymore @PatrickJS ?

@nmaves
Copy link

nmaves commented Jun 27, 2022

I talked with @PatrickJS via twitter and he would love to get a PR in for TypeScript. @dwelch2344 you got any time to help with this?

@dwelch2344
Copy link

@nmaves absolutely! ping me on twitter at david_welch!

@sutt0n
Copy link

sutt0n commented Jan 16, 2024

@PatrickJS @nmaves @dwelch2344 Did anything come of this?

@dwelch2344
Copy link

Timing's amazing. Sadly not, but we're just implementing our data loader strategy at work now and so this bubbled up last week.

We're on the fence of a PR/rewrite vs just contributing TypeDefs. The lib's small enough and the world of TS in 2024 is pretty appealing...

@PatrickJS
Copy link
Owner

@dwelch2344 if you want we can work together on the rewrite and then I can publish it as the new version and add whoever is working on it to the repo and package.

@dwelch2344
Copy link

@PatrickJS would love to! DMing ya on the bird

@sutt0n
Copy link

sutt0n commented Jan 22, 2024

I'd be down to get involved as well. Bird handle is the same as GH.

@dwelch2344
Copy link

@sutt0n awesome! talked with @PatrickJS and we're gonna split the work.

I'm going to setup a fork with a clean branch and a simple tsconfig project. Will add a proposed interface for the loader lib, and a few unit tests.

Will open a PR so we can all comment on the desired shape / etc, then can hash out the impl.

Sound good?

@sutt0n
Copy link

sutt0n commented Jan 23, 2024

@dwelch2344 Sounds good!

@PatrickJS
Copy link
Owner

If I lose track of this it's because notifications are lost. And DM on twitter for fast response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants