Add SqlTransport Source and Add Azure Service Bus Target #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rob Van Pamel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 2 commits
January 30, 2023 16:26
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I created this PR to address the changes we are currently taken to resolve #494. There is still work to be done in this PR to follow all the guidelines which you have in the others, but it already allows us to copy messages from the source to the target.
So before adding more effort to this PR, I would like to discuss if it makes sense to add this source and target to the project.
The scenario:
We have several endpoints using SQL Transport (SQL Island) but also endpoints using an Azure Service Bus Transport (ASB Island). Currently those are connected using the opensource project 'NServicebus.Router '.
As this router is adding increased confusion and complexity, we would like to remove this and move all the endpoints to ASB only. This is planned to be completed by the end of Q1 2023. On the SQL Island we have several messages which are delayed by several months for up to a year. So we would need to move these messages as well, so we found that this project could be a good starting point.
Actions done:
Create a SQLTransport source:
This is mostly a copy of the existing (Not Native) Sql source which is afterwards adapted to the native SQLTransport.
Create a ASB target:
This follows most of the guidelines which I saw in the other targets.
Things to be done