Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move environment specific checks into validation context #4141

Open
mikeminutillo opened this issue May 3, 2024 · 0 comments
Open

Move environment specific checks into validation context #4141

mikeminutillo opened this issue May 3, 2024 · 0 comments

Comments

@mikeminutillo
Copy link
Member

Describe the suggested improvement

Is your improvement related to a problem? Please describe.

In #4128 and #4129 we introduced a temporary cache for environment-specific information which the viewmodel validation code uses to ensure that the user does not re-use paths, ports, connection strings, etc.

Describe the suggested solution

Hook this environment specific code into validation context root context data. The parent view model can load this once and provide it to the validators, which will ignore those rules if the validation context does not contain this data. That will also make the validators much easier to test as we can set an appropriate context and test the specific rules we care about.

Describe alternatives you've considered

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant