Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageRedirectsController has conceptional but partial duplication #4018

Open
danielmarbach opened this issue Mar 18, 2024 · 0 comments
Open

Comments

@danielmarbach
Copy link
Contributor

Describe the suggested improvement

MessageRedirectsController has the possibility to create new redirects or updating existing redirects. Creating new redirects involves validation of the input data and handling of more elaborate conflict handling with potentially existing or dependent redirects.

Updating redirects doesn't provide the same validation. It checks for existing redirects but uses different reason phrases but doesn't check for dependents.

Additionally, MessageRedirectRequest contains RetryExisting which is never used by ServicePulse. This flag on the input data model is never checked on the update redirects call.

It might be worthwhile cleaning up the controller and the input model.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant