We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessageRedirectsController has the possibility to create new redirects or updating existing redirects. Creating new redirects involves validation of the input data and handling of more elaborate conflict handling with potentially existing or dependent redirects.
Updating redirects doesn't provide the same validation. It checks for existing redirects but uses different reason phrases but doesn't check for dependents.
Additionally, MessageRedirectRequest contains RetryExisting which is never used by ServicePulse. This flag on the input data model is never checked on the update redirects call.
MessageRedirectRequest
RetryExisting
It might be worthwhile cleaning up the controller and the input model.
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the suggested improvement
MessageRedirectsController has the possibility to create new redirects or updating existing redirects. Creating new redirects involves validation of the input data and handling of more elaborate conflict handling with potentially existing or dependent redirects.
Updating redirects doesn't provide the same validation. It checks for existing redirects but uses different reason phrases but doesn't check for dependents.
Additionally,
MessageRedirectRequest
containsRetryExisting
which is never used by ServicePulse. This flag on the input data model is never checked on the update redirects call.It might be worthwhile cleaning up the controller and the input model.
Additional Context
No response
The text was updated successfully, but these errors were encountered: