From 5f3f0e059582e06eeef1f63d869bac5c73fe77a1 Mon Sep 17 00:00:00 2001 From: Daniel Marbach Date: Tue, 12 Mar 2024 09:08:56 +0000 Subject: [PATCH] Remove TODOs on input models since we want to keep this consistent for now (#4000) --- src/ServiceControl/Notifications/Api/ToggleEmailNotifications.cs | 1 - .../Notifications/Api/UpdateEmailNotificationsSettingsRequest.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/ServiceControl/Notifications/Api/ToggleEmailNotifications.cs b/src/ServiceControl/Notifications/Api/ToggleEmailNotifications.cs index 82221a26cb..54c0096987 100644 --- a/src/ServiceControl/Notifications/Api/ToggleEmailNotifications.cs +++ b/src/ServiceControl/Notifications/Api/ToggleEmailNotifications.cs @@ -4,7 +4,6 @@ public class ToggleEmailNotifications { - // TODO In theory this is not needed because we are using the snake case converter [JsonPropertyName("enabled")] public bool Enabled { get; set; } } diff --git a/src/ServiceControl/Notifications/Api/UpdateEmailNotificationsSettingsRequest.cs b/src/ServiceControl/Notifications/Api/UpdateEmailNotificationsSettingsRequest.cs index 348ac34b25..7cb84cbed9 100644 --- a/src/ServiceControl/Notifications/Api/UpdateEmailNotificationsSettingsRequest.cs +++ b/src/ServiceControl/Notifications/Api/UpdateEmailNotificationsSettingsRequest.cs @@ -4,7 +4,6 @@ public class UpdateEmailNotificationsSettingsRequest { - // TODO In theory this is not needed because we are using the snake case converter (rest the same) [JsonPropertyName("smtp_server")] public string SmtpServer { get; set; }