Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify verification tests #266

Open
rfvander opened this issue Aug 20, 2017 · 1 comment
Open

Modify verification tests #266

rfvander opened this issue Aug 20, 2017 · 1 comment
Assignees

Comments

@rfvander
Copy link
Contributor

I just came across an issue with the stencil code (Fenix version, using OpenMPI 1.7.1 on a 4-node, 64 rank Xeon cluster). Problem size was 3584 and the number of iterations 2560. No errors injected. The test failed twice in a row:
ERROR: L1 norm = 5121.999940, Reference L1 norm = 5122.000000
ERROR: L1 norm = 5121.999999, Reference L1 norm = 5122.000000
In both cases the relative error was less than 1.e-8, but the absolute error exceeded that limit. While it is conceivable there is an error in the runtime (the same run on a 36-core HSW system succeeded), the error is small enough that it should have passed. I feel we should update all the verification tests to measure relative error, not absolute.

@rfvander
Copy link
Contributor Author

Assignment accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants