Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose player info forwarding in the API ( Fix #1063 ) #1064

Open
wants to merge 3 commits into
base: dev/3.0.0
Choose a base branch
from
Open

Expose player info forwarding in the API ( Fix #1063 ) #1064

wants to merge 3 commits into from

Conversation

kyngs
Copy link
Contributor

@kyngs kyngs commented Aug 21, 2023

Fix #1063

hugmanrique
hugmanrique approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@hugmanrique hugmanrique left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😀 (The CI fails due to an incorrect order of imports)

@kyngs
Copy link
Contributor Author

kyngs commented Aug 21, 2023

Hang on, gotta make checkstyle happy with the import order

Xernium
Xernium requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@Xernium Xernium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires approval by @astei as he made a very deliberate effort in ensuring this does not get exposed to the API.

@Xernium Xernium requested a review from astei August 21, 2023 15:32
@kyngs
Copy link
Contributor Author

kyngs commented Aug 21, 2023

This requires approval by @astei as he made a very deliberate effort in ensuring this does not get exposed to the API.

May I ask the reason?

@electronicboy
Copy link
Member

The intention is to avoid exposing implementation details to plugins, especially given that things like Configuration are not API

I do wonder the use-case for this sorta thing, the forwarding mode should be effectively transparent to plugins, and have no real impacts elsewhere

@kyngs
Copy link
Contributor Author

kyngs commented Aug 21, 2023

I do wonder the use-case for this sorta thing, the forwarding mode should be effectively transparent to plugins, and have no real impacts elsewhere

My practical use case is setting up nano limbo on-demand from the proxy. To do so, I need to forward the forwarding configuration to it.

@kyngs
Copy link
Contributor Author

kyngs commented Sep 14, 2023

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xernium Xernium Xernium requested changes

@hugmanrique hugmanrique hugmanrique approved these changes

@astei astei Awaiting requested review from astei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose forwarding related configuration data in ProxyConfig.
4 participants
@kyngs @electronicboy @hugmanrique @Xernium