Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname/IP validation is too strict #1031

Open
RaphiMC opened this issue Jun 28, 2023 · 6 comments
Open

Hostname/IP validation is too strict #1031

RaphiMC opened this issue Jun 28, 2023 · 6 comments
Labels
type: feature New feature or request

Comments

@RaphiMC
Copy link

RaphiMC commented Jun 28, 2023

If I want to use raphimc.net_25564_1.8.x.viaproxy.127-0-0-1.nip.io:25568 as a hostname for my backend server in the velocity config it complains that the address is not valid. Pinging raphimc.net_25564_1.8.x.viaproxy.127-0-0-1.nip.io in cmd resolves to localhost as it should. The reason I want to use such a long hostname is to pass on information (Through the address in the handshake packet) to the "backend server" (Another proxy) to know where to connect to. Trying to connect to that address with a minecraft client works fine.

@RaphiMC
Copy link
Author

RaphiMC commented Jun 28, 2023

Bungeecord has the same issue: SpigotMC/BungeeCord#3480

@electronicboy
Copy link
Member

I mean, you're breaking the hostname spec, I guess we probably should relax this a little, but, idk what extra chars we allow people to break the spec with

@RaphiMC
Copy link
Author

RaphiMC commented Jun 28, 2023

Which of the characters breaks the hostname spec?

@electronicboy
Copy link
Member

electronicboy commented Jun 28, 2023 via email

@RaphiMC
Copy link
Author

RaphiMC commented Jun 28, 2023

Just tried, even browsers accept _ in the URLs. So I think it should be relaxed even tho its not strictly per spec

@electronicboy
Copy link
Member

electronicboy commented Jun 28, 2023 via email

@Nacioszeczek Nacioszeczek added the type: feature New feature or request label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants