Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeModfiers is not removed when the player dies #10684

Closed
huimanman opened this issue May 10, 2024 · 2 comments
Closed

AttributeModfiers is not removed when the player dies #10684

huimanman opened this issue May 10, 2024 · 2 comments
Labels
resolution: works as intended Working as it should / expected to type: bug Something doesn't work as it was intended to. version: 1.20.6 Game version 1.20.6

Comments

@huimanman
Copy link

Expected behavior

All modifiers added by /attribute are removed upon death

Observed/Actual behavior

The modifiers added by /attribute to still exist after rebirth

Steps/models to reproduce

  1. run /attribute @s minecraft:generic.armor modifier add 1-0-0-0-0 "" 1 add_value
  2. run /attribute @s minecraft:generic.armor modifier value get 1-0-0-0-0
  3. run /kill @s
  4. Respawn
  5. Run again /attribute @s minecraft:generic.armor modifier value get 1-0-0-0-0

Plugin and Datapack List

plugins
[10:43:44 INFO]: Server Plugins (0):

datapack list
[10:44:13 INFO]: There are 3 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)], [paper (built-in)]
[10:44:13 INFO]: There are no more data packs available

Paper version

version
[10:44:27 INFO]: Checking version, please wait...
[10:44:28 INFO]: This server is running Paper version git-Paper-55 (MC: 1.20.6) (Implementing API version 1.20.6-R0.1-SNAPSHOT) (Git: 1b67e02)
You are running the latest version

Other

No response

@huimanman huimanman added status: needs triage type: bug Something doesn't work as it was intended to. labels May 10, 2024
@papermc-sniffer papermc-sniffer bot added the version: 1.20.6 Game version 1.20.6 label May 10, 2024
@Malfrador
Copy link
Member

Malfrador commented May 10, 2024

Attributes being reset on death is considered a bug by Mojang: https://bugs.mojang.com/browse/MC-179940

Paper generally aims to fix bugs, especially if they are confirmed by Mojang but unfixed. I'm inclined to say this is working as intended for that reason, but maybe there are other opinions on this.

If this is fixed at all, it would need to be only fixed for modifiers applied by the command which seems complicated. Changing this behaviour for the API too would be a major API break, and needlessly annoying for plugins who then need to listen to an additional event to reapply modifiers.

Edit: Mojang has fixed MC-179940, presumably for 1.21.

@Machine-Maker
Copy link
Member

This is officially "works as intended" as Mojang have fixed the linked issue. Attributes are expected to be retained on player deaths.

@Machine-Maker Machine-Maker closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@Machine-Maker Machine-Maker added resolution: works as intended Working as it should / expected to and removed status: needs triage labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: works as intended Working as it should / expected to type: bug Something doesn't work as it was intended to. version: 1.20.6 Game version 1.20.6
Projects
Status: Invalid
Development

No branches or pull requests

3 participants