Chore: Update terminal dependencies #10675
Draft
+79
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to also look into log4j, but, so far 1) Updated to jline-terminal 3.26.1 - jline, however, has deprecated their jansi provider, and so, we're going back to JNA. FFM looks interesting, but, might not work on java 21, and, seems to requore some additional java flags to open stuff up to allow it to work, however, seemed to work without on macOS? 2) added a hackaround to try to migate the terminal issues we're facing on windows, will probably look towards adding a detection step for PS7 so we can disable the hack, but, in the meantime, this at least works around the issue.
electronicboy
added
the
build-pr-jar
electronicboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to also look into log4j, but, so far
Updated to jline-terminal 3.26.1 - jline, however, has deprecated their jansi provider,
and so, we're going back to JNA. FFM looks interesting, but, might not work on java 21,
and, seems to requore some additional java flags to open stuff up to allow it to work,
however, seemed to work without on macOS?
added a hackaround to try to migate the terminal issues we're facing on windows, will
probably look towards adding a detection step for PS7 so we can disable the hack, but,
in the meantime, this at least works around the issue.
(Closes #10674)
(Closes #10405)
Cross ref: jline/jline3#952