Shulkers loaded from bukkit yml have no nbt on contents

[ghost]

Expected behavior

If you have an item with NBT within a shulker serialized into yaml, after deserialization the item should have nbt?

Observed/Actual behavior

All items in the shulker are stripped of nbt (yikes)

Steps/models to reproduce

Serialize itemstack to yml

Plugin and Datapack List

N/A

Paper version

This server is running Paper version git-Paper-"7ae2c67" (MC: 1.20.6) (Implementing API version 1.20.6-R0.1-SNAPSHOT) (Git: 7ae2c67)
You are running the latest version
Previous version: git-Paper-"0db72ac" (MC: 1.20.6)

Other

No response

[ghost]

IMO remove/hard deprecate itemstack yaml serialization entirely, its very dangerous.

[lynxplay]

Yea, we have been thinking about it for a while.
I don't think there is much saving we can do for you on any of these issues.

[ghost]

Yea, we have been thinking about it for a while. I don't think there is much saving we can do for you on any of these issues.

Don't worry, luckily this was caught in testing, I plan to migrate entirely away from yaml, however, I worry for others.

[Machine-Maker]

@ThrowerWay can you clarify what you mean by "an item with NBT"? I tested this by putting 2 stacks in an anvil and renaming them, then putting them in a shulker. after serializing to yaml and back, they still had the custom names. Did you mean actually "custom" nbt, like in the custom_data component?

Some exact reproduction steps would be good, cause I can't seem to reproduce this.

[ghost]

@ThrowerWay can you clarify what you mean by "an item with NBT"? I tested this by putting 2 stacks in an anvil and renaming them, then putting them in a shulker. after serializing to yaml and back, they still had the custom names. Did you mean actually "custom" nbt, like in the custom_data component?

Some exact reproduction steps would be good, cause I can't seem to reproduce this.

try upgrading from 1.20.4, by custom nbt i mean, lore, display name, enchants, persistant data container etc.

[Machine-Maker]

Can you send some itemstacks serialized into yaml in 1.20.4 so I can test upgrading them?

[lynxplay]

Closing this as it has been without activity for 3 weeks.