Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquatic creatures spawned using buckets do not have the persistent tag #10625

Open
Lightningtow opened this issue Apr 29, 2024 · 4 comments
Open
Labels
resolution: awaiting response Additional information is required from the issue reporter type: bug Something doesn't work as it was intended to. version: 1.20.4 Game version 1.20.4

Comments

@Lightningtow
Copy link

Lightningtow commented Apr 29, 2024

Expected behavior

According to the wiki, creatures spawned using a Bucket of should be marked as persistent and not despawn. Note this seems to be a bug within vanilla Minecraft itself. I have also reported this to Mojang here.

Observed/Actual behavior

Placing creatures via Bucket of <creature> doesn't properly give them the persistent tag, leading to them quickly despawning.

The fish didn't spawn with the persistent tag regardless of survival or creative, or whether placing the animal into water that was already there. It doesn't matter whether the item was obtained from the creative inventory, or was an empty bucket that later picked up a fish. It affects buckets of cod, salmon, tropical fish, pufferfish, axolotl, and tadpole.

Steps/models to reproduce

  1. Place a bucket of <creature>.
  2. Run /data get entity @e[limit=1,sort=nearest,type=!player]
  3. Note that the tag "PersistenceRequired" is equal to 0b instead of 1b as it should be. (The tag "FromBucket" is 1b, as intended.)

Plugin and Datapack List

This reproduced on a fresh installation of paper with no plugins or additional datapacks. /datapack list returns only
[vanilla (built-in)], [file/bukkit (world)].

Paper version

This server is running Paper version git-Paper-496 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 7ac24a1 on ver/1.20.4)
You are running the latest version

Other

Within the blurb returned by the /data get entity command, amongst it was Paper.SpawnReason: "SPAWNER_EGG". I don't know if this should be "spawned with a bucket" instead, or if it's at all relevant to this issue.
paper_1 20 4_bucket_thing
2024-04-29_15 05 52

@Lightningtow Lightningtow added status: needs triage type: bug Something doesn't work as it was intended to. labels Apr 29, 2024
@papermc-sniffer papermc-sniffer bot added the version: 1.20.4 Game version 1.20.4 label Apr 29, 2024
@Machine-Maker
Copy link
Member

Machine-Maker commented Apr 29, 2024

Are you sure the entities are actually despawning? Setting that tag isn't the only thing the game uses to know if the entity can be despawned.

@Machine-Maker Machine-Maker added resolution: awaiting response Additional information is required from the issue reporter and removed status: needs triage labels Apr 29, 2024
@Lightningtow
Copy link
Author

They definitely disappeared from my aquarium I built, but it's possible they simply died. I'm not sure what specifically you mean by "Setting that tag isn't the only thing the game uses to know if the entity can be despawned." Are you saying the presence of the FromBucket:1b tag or some other tag is enough to prevent it from despawning?

From the wiki:

Tropical fish caught in buckets then released do not despawn, unlike mobs that spawn naturally in their aquatic environments.

@Machine-Maker
Copy link
Member

Yes, the from bucket check should be enough to prevent despawning.

@Lightningtow
Copy link
Author

Any suggestions on how to track whether they're despawning vs dying? Only thing I can think of is that EssX tracks named deaths, but that would require naming them thus messing up the despawning test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: awaiting response Additional information is required from the issue reporter type: bug Something doesn't work as it was intended to. version: 1.20.4 Game version 1.20.4
Projects
Status: ⌛ Awaiting Response
Development

No branches or pull requests

2 participants