Fix crafting in custom inventories #7265
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
changed the title
Machine-Maker
force-pushed
the
fix/view-custom-inventory
branch
from
c02ee1b
to
d83f8f8
Compare
|
Now includes fixes for Looms and Stonecutters. Also fixes #5825 now. |
3 tasks
This was
linked to
issues
Jan 13, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
fix/view-custom-inventory
branch
from
d83f8f8
to
878d507
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue. |
Machine-Maker
force-pushed
the
fix/view-custom-inventory
branch
from
878d507
to
9e7cfd3
Compare
Machine-Maker
force-pushed
the
fix/view-custom-inventory
branch
2 times, most recently
from
17bb786
to
44b7388
Compare
Machine-Maker
force-pushed
the
fix/view-custom-inventory
branch
from
44b7388
to
0d73648
Compare
kashike
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some pretty absurd solutions I think to fix some existing issues with bukkit's inventory system and inventories created vis Bukkit.createInventory(). I recommend people use the HumanEntity#openSomething methods cause those are going to be pretty good, but they don't afford as much customization as the other ones.
Creating this as a draft because I haven't tested all the inventories and I'm sure others suffer from the same problem anvil, smithing tables, and enchant tables did. It's mainly non-tile-entity crafting block inventories, so I think looms, stonecutters, and grindstones are probably affected.
Fixes #10621
Fixed