Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messages after upstream chunk api update #96

Open
masmc05 opened this issue Jun 18, 2023 · 0 comments
Open

Improve messages after upstream chunk api update #96

masmc05 opened this issue Jun 18, 2023 · 0 comments
Labels
status: needs triage type: feature Request for a new Feature.

Comments

@masmc05
Copy link

masmc05 commented Jun 18, 2023

Is your feature request related to a problem?

Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions.

image
image
image

Describe the solution you'd like.

Update the used nms getChunk method or change the method to a newer one

Describe alternatives you've considered.

use proper isTickThread check (or maybe even better ensureTickThread)

Other

The people who used chunk object correctly and only from main thread shouldn't see a difference.

@masmc05 masmc05 added status: needs triage type: feature Request for a new Feature. labels Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: feature Request for a new Feature.
Projects
None yet
Development

No branches or pull requests

1 participant