Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix broken docs generation #553

Merged

Conversation

michalbil
Copy link
Collaborator

@michalbil michalbil commented Mar 12, 2024

Description

Update m2r package version to 0.3.1, done by executing:

poetry add -G dev m2r@^0.3.1

Motivation and Context

Resolves #552

How Has This Been Tested?

By executing poetry run make docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil added bug documentation dependencies Pull requests that update a dependency file labels Mar 12, 2024
@paulmnguyen
Copy link
Contributor

HI, there is a conflict in between the branch's. Do you happen to know which one is the correct resolution?

@michalbil
Copy link
Collaborator Author

HI, there is a conflict in between the branch's. Do you happen to know which one is the correct resolution?

@paulmnguyen I can see that in the meantime a change has been done in pyproject.toml. Let me update the PR.

@jamesholland-uk jamesholland-uk removed the request for review from btorresgil May 31, 2024 10:18
@jamesholland-uk
Copy link
Member

#564 has fixed the workflow code and the issue of CI tests failing, but rerunning the jobs uses the old workflow code. Going to merge this as it works with the new workflow code

@jamesholland-uk jamesholland-uk merged commit 285429f into PaloAltoNetworks:develop May 31, 2024
3 of 7 checks passed
Copy link

🎉 This PR is included in version 1.12.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

@michalbil michalbil deleted the fix-docs-generation branch June 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing make docs - Could not import extension m2r
4 participants