Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make PRs that use http requests? #32

Open
alanbacon opened this issue Mar 27, 2020 · 2 comments
Open

Can we make PRs that use http requests? #32

alanbacon opened this issue Mar 27, 2020 · 2 comments

Comments

@alanbacon
Copy link
Contributor

There is a certain feature I wanted to make a PR for, but the feature only works over HTTP, and not with the XML interface.

Can you see a problem with this? Are you trying to support devices that don't support the JSON API?

@alanbacon
Copy link
Contributor Author

Actually managed to work this out using XML, but I'm still interested in the answer to this question

@PSeitz
Copy link
Owner

PSeitz commented Mar 27, 2020

JSON and XML are both HTTP, just different formats. Older receivers support only XML, newer support both, so XML is preferable for compatiblity.
If there is something only available for JSON, I would not mind integrating it, but I can't test it, because my receiver is too old :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants