Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pandas args to overridden methods #212

Open
MaxGhenis opened this issue Mar 5, 2021 · 0 comments
Open

Add pandas args to overridden methods #212

MaxGhenis opened this issue Mar 5, 2021 · 0 comments

Comments

@MaxGhenis
Copy link
Collaborator

We haven't yet implemented many args in overridden methods, but leaving them off violates substitutability. It'd be good to include them and raise NotImplementedErrors when those args aren't yet implemented in a way that can be just passed to super().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaxGhenis