Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted MASE for Hindcast Cross-Validation #37

Open
MOshima-PIFSC opened this issue May 9, 2022 · 2 comments
Open

Adjusted MASE for Hindcast Cross-Validation #37

MOshima-PIFSC opened this issue May 9, 2022 · 2 comments
Labels
enhancement New feature or request status: low priority Low-priority issue.

Comments

@MOshima-PIFSC
Copy link
Contributor

MOshima-PIFSC commented May 9, 2022

As per Henning's email to Nicholas, a potential update for the adjusted MASE could be implemented that only adjusts the naïve prediction residuals with minimal contrast instead of the MAE (current method). To do this the following changes would be made to SSmase.R (lines 231-234):

scaler <- mean(abs(naive.eval))
scaler <- mean(pmax(abs(naive.eval),MAE.base.adj)
mase <- maepr / scaler
mase.adj <- maepr /scaler.adj

This method would be more targeted at adjusting specific years with very low contrast vs. the entire timeseries.
Additionally, it would be helpful to update the documentation for this function, in the R script and the user handbook to improve understanding of the application and interpretation.

@N-DucharmeBarth-NOAA would you have time and be willing to help us work on this issue to improve the MASE function?

@N-DucharmeBarth-NOAA
Copy link
Contributor

@MOshima-PIFSC let me finish up this blue shark assessment work first and then I can make time to help out with this issue.

@MOshima-PIFSC
Copy link
Contributor Author

Thanks @N-DucharmeBarth-NOAA no rush!

@efletcherPIFSC efletcherPIFSC added documentation Improvements or additions to documentation enhancement New feature or request labels May 13, 2022
@efletcherPIFSC efletcherPIFSC added this to the ss3diags 2.1.0 milestone Jun 1, 2022
@efletcherPIFSC efletcherPIFSC removed the documentation Improvements or additions to documentation label Jul 5, 2022
@efletcherPIFSC efletcherPIFSC added the status: low priority Low-priority issue. label Aug 11, 2022
@efletcherPIFSC efletcherPIFSC removed this from the ss3diags 2.1.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status: low priority Low-priority issue.
Projects
Development

No branches or pull requests

3 participants