Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected songs are not properly highlighted in playlist view #773

Closed
4 tasks done
nitinsooni opened this issue May 7, 2024 · 5 comments
Closed
4 tasks done

Selected songs are not properly highlighted in playlist view #773

nitinsooni opened this issue May 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working non-criticial Will fix later ui Related to app UI

Comments

@nitinsooni
Copy link

Description

When select a song, show 'Select All' option in menu to select all songs. Obviously in songs, album, artist,... tabs, but inside playlists also.

And very minor bug, so don't wanna open new issue. When selects song inside playlists, songs don't highlights like in songs tab.

Problem solved

No response

Other implementations

.

Benefit

Can save hard labour.

Duplicates

@nitinsooni nitinsooni added the enhancement New feature or request label May 7, 2024
@OxygenCobalt
Copy link
Owner

There's no more room in the UI to add any kind of "select all" option unfortunately. However I do notice the highlight issue, so I'm converting this to a bug issue regarding that.

@OxygenCobalt OxygenCobalt changed the title Select All Songs Option Selected songs are not properly highlighted in playlist view May 7, 2024
@OxygenCobalt OxygenCobalt added bug Something isn't working ui Related to app UI non-criticial Will fix later and removed enhancement New feature or request labels May 7, 2024
@nitinsooni
Copy link
Author

Yeah you are right about the limited room.

There are 2 options which do same kind of things - 'add to queue', 'play next'.

  • add to queue, adds songs to queue in last position
  • play next, adds songs to next in queue

You should use approach like spotify, only have add to queue option which add songs in next position

Screenshot_20240508-001322

And i also have doubts on 'only selected songs shuffle' option, doubt much people use that.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented May 7, 2024

I used to have Spotify's queue. However, more people expect Play Next/Add to queue over Spotify's weird transient queue. It's also significantly harder to implement internally. There are also a good amount of people that want to select a specific queue to play.

I'm also not talking about the menu UI. I'm talking about the album/artist/genre view, there is more or less no space to put anything like "select all" without making it cluttered.

@nitinsooni
Copy link
Author

Okay thanks for sharing your thoughts.

Btw, if you can clarify this because there is no discussion tab. I don't know if its a bug or my music tag have issue, but my app showing multiple albums for different artists.
Screenshot_20240508-003105
I selected comma in multi value seperator and also my music's tag artists are seperated by commas.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented May 7, 2024

Yeah, currently you need to have album artist tags @nitinsooni until I can do #750. Basically, it's easier technically to group by album and artist combination rather than just album, which leads to this splitting since the album's tracks will be grouped separately based on their artist combinations. If they have the same album artist tag, they will be correctly grouped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-criticial Will fix later ui Related to app UI
Projects
None yet
Development

No branches or pull requests

2 participants