Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic playback screen coloring #764

Open
OxygenCobalt opened this issue Apr 22, 2024 · 8 comments
Open

Dynamic playback screen coloring #764

OxygenCobalt opened this issue Apr 22, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request maybe Uncertain if this will be done ui Related to app UI

Comments

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Apr 22, 2024

I've rejected this prior, but a few developments have occurred that have justified this:

  1. It's now an official recommendation of the Material3 spec
  2. MDC now has a way to extract color palettes from images using Monet (I think...)
  3. Material Design 3.1 #743 is making the playback view more likely to play along with this.
  4. I think I have a way to implement this technically that would not be an absolute nightmare (Basically I have a mini shared object scoped to the fragment lifecycle that hooks into the image loader and animates the colors across all UI components that subscribe to it)

This is likely to be made an unchangeable default, and it will be solely scoped to the playback screen to keep myself sane. Technical/performance implications need to be worked out however.

@OxygenCobalt OxygenCobalt added enhancement New feature or request ui Related to app UI maybe Uncertain if this will be done labels Apr 22, 2024
@OxygenCobalt OxygenCobalt self-assigned this Apr 22, 2024
@KraXen72
Copy link

HUGE IF TRUE

@HyperWinX
Copy link

Omg, we will wait for it!

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented May 4, 2024

Update: Apparently MDC's palette extraction uses a weird hacky theming thing that only works on Android 12+. I'll still have to use a third-party library still to make it work on older android versions and actually properly animate it.

@KraXen72
Copy link

https://github.com/AkaneTan/Gramophone has implemented this and is open source. that is all i'll say.

@OxygenCobalt
Copy link
Owner Author

Looking at the source code... yeah this is easier than I thought. Huh. @KraXen72

Still only limited to Android 12 by design, frustratingly.

@KraXen72
Copy link

there are more things in that music player that could 'inspire' you, if you want

their now-playing screen is pretty clean:
Screenshot_20240519-011736_Gramophone.png

@OxygenCobalt
Copy link
Owner Author

Yeah, it looks better @KraXen72. I actually used it as partial inspiration over at #743, but I disagree with the button placement.

@KraXen72
Copy link

yeah the bottom button placement is pretty cluttered there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe Uncertain if this will be done ui Related to app UI
Projects
None yet
Development

No branches or pull requests

3 participants