WIP: Use new maven rules #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Steve, I think that the PR should be better merged into its own branch, (f.ex: develop, feature/rules_jvm_external, preferably with a feature prefix like in GitFlow), at least I would feel more comfortable. Later, after more maturing of the feature branch, and ageing of master branch, this branch itself can be merged into master. What do you think? Orhan |
|
Hi Steve, I created a develop branch, from master to develop, and a feature branch, from develop to feature/use-new-maven-rules. Regards, Orhan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
This state is basically working, but currently I'm struggling with a bug in the used rule. Until this bug is fixed, I cannot guruantee this patch to be working 100%.