Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search type settings should be per index not global #15891

Open
MikeAlhayek opened this issue Apr 26, 2024 · 2 comments
Open

Search type settings should be per index not global #15891

MikeAlhayek opened this issue Apr 26, 2024 · 2 comments
Milestone

Comments

@MikeAlhayek
Copy link
Member

Currently, we have a way to define the default search settings which then is applied to every searched index. Below is a screenshot of an example.

The problem here is that the search UI supports multiple index search. So when we search for a non-default index, the non-default index will try to search using the default index settings which is a problem.

Each index should have their own search settings (Search type, default fields or a custom search query) so if the user is searching against a non-default index, the UI will utilize the settings for the used index not the default settings.

The Default search index options is still should be kept as global but not the "Default search type", "Default Query", and "Default searched fields"

image

@MikeAlhayek MikeAlhayek modified the milestones: 1.9, 1.x Apr 26, 2024
@Anmol46
Copy link

Anmol46 commented Apr 27, 2024

I want to clarify some things. If the user is searching against a non-default index and if the non-default index is used before then the UI should utilize the previously used settings. Did I get it right?

@MikeAlhayek
Copy link
Member Author

@Anmol46 No exactly. Each index should have a separate settings so that each index can specify different search strategy.

The SearchSettings will tell us which index to use by default if the user did not specify the index name in the URL. When we perform the search, we’ll load the settings for the select index. This was each index can have different settings as needed.

let me know if you want to submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants