Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Support for Loading Translations #11356

Open
hishamco opened this issue Mar 11, 2022 · 2 comments · May be fixed by #15886
Open

Async Support for Loading Translations #11356

hishamco opened this issue Mar 11, 2022 · 2 comments · May be fixed by #15886
Labels
enhancement localization perf
Milestone
2.x

Comments

@hishamco
Copy link
Member

While I'm working on DataLocalization support, I realize that ITranslationProvider.LoadTranslations should support async for loading translations from database or any store without blocking.

I know this will be a breaking change but it's good improvement for 2.0.0
@sebastienros
Copy link
Member

It's a minor breaking change, I don't think many have implemented this. Maybe check if we have a breaking change label, and create it if not to add it to the PR. Also change the release instructions to check for this label and mention them in the release notes.

@sebastienros sebastienros added this to the 1.x milestone Mar 17, 2022
@sebastienros
Copy link
Member

Not sure about the NuGet packages though, it's not just Orchard CMS.

@hishamco hishamco added the breaking change 💥 Issues or pull requests that introduces breaking change(s) label Mar 17, 2022
@hishamco hishamco linked a pull request Apr 26, 2024 that will close this issue
Open
@hishamco hishamco removed the breaking change 💥 Issues or pull requests that introduces breaking change(s) label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement localization perf
Projects
None yet
Milestone
2.x
Development

Successfully merging a pull request may close this issue.

Add ITranslationProvider.LoadTranslationsAsync() OrchardCMS/OrchardCore
3 participants
@sebastienros @Piedone @hishamco