Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation to be closer to design specs #366

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 28, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #365.

Description

Removed license, team and cookies from the sidebar.
Update footer links.
Add a supra bar.
Add GitHub link.
Need to check the design with designers.

See another rendering or see first comment

image
image
image
image

Motivation & Context

? Read #365.

Types of change

  • Refactoring (non-breaking change)

Checklist

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test on simulators and on a physical device (Android & iOS, orientation change, dark/light mode)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for ods-flutter ready!

Name Link
🔨 Latest commit 7fd29bb
🔍 Latest deploy log https://app.netlify.com/sites/ods-flutter/deploys/66151931a0c7a70009f867a8
😎 Deploy Preview https://deploy-preview-366--ods-flutter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond
Copy link
Member

julien-deramond commented Mar 28, 2024

One possible solution for the mobile rendering as a quick win:

Screenshot 2024-03-28 at 15 59 21

By adding width: 100% and border-left: 0 to the <div id="offcanvasWrapper"> (somewhere around this <div>).

@louismaximepiton louismaximepiton marked this pull request as ready for review April 18, 2024 08:46
@julien-deramond julien-deramond self-requested a review April 24, 2024 20:17
@julien-deramond julien-deramond added 📖 documentation Improvements or additions to documentation 🧩 enhancement labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 🧩 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Update the supra bar and footers
2 participants