Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types in ods-chart-popover.ts #157

Closed
julien-deramond opened this issue Mar 12, 2024 · 0 comments · Fixed by #218
Closed

Add missing types in ods-chart-popover.ts #157

julien-deramond opened this issue Mar 12, 2024 · 0 comments · Fixed by #218
Labels
enhancement New feature or request library

Comments

@julien-deramond
Copy link
Member

Description

In https://github.com/Orange-OpenSource/ods-charts/pull/107/files#diff-7550ed8e96cefb56f155fd7d28958f936ff45aa4c689fab605c009c7477b48a1, we've introduced a new algorithm to override the tooltip.confine: true configuration.

However, this implementation was done in pure JavaScript, and not in TypeScript.

The idea of this issue is to refactor a little bit the code to:

  • Add the correct types in the position: (...) => fallback
  • Rename correctly the intermediate variables in this function (e.g. no more obj and tmp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant