Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possible unused codebook entries #5

Open
necros2k7 opened this issue Jul 11, 2022 · 1 comment
Open

Remove possible unused codebook entries #5

necros2k7 opened this issue Jul 11, 2022 · 1 comment
Labels
enhancement New feature or request hacktoberfest Issues you can help with for Hacktoberfest!

Comments

@necros2k7
Copy link

necros2k7 commented Jul 11, 2022

subj

@AlexTMjugador
Copy link
Member

AlexTMjugador commented Jul 11, 2022

Hi, thanks for trying out OptiVorbis!

Regarding your question:

  • The first highlighted vorbis string is required by the Vorbis specification to be present: it is the Vorbis identification packet header signature.
  • The second highlighted OggS string is the Ogg page capture pattern, which is required by the Ogg container specification to signal the beginning of a page. The Vorbis specification requires that this second page is present: the identification header must be alone on its own page.
  • The second highlighted vorbis string is required, and it is used as the Vorbis comment header signature, which is mandatory.
  • The third highlighted vorbis string, which is followed by the codebook count and the sync pattern BCV for the first codebook, is also required by the Vorbis specification.
  • The highlighted mostly-zero bytes may be optimized further. It's difficult to say for sure without proper analysis, but they look like unused codebook entries, and it looks feasible to remove them, although doing it properly is a bit complicated and not implemented yet.

@necros2k7 necros2k7 changed the title Can we remove this "junk" data somehow? Feat.req. Remove possible unused codebook entries Jul 12, 2022
@AlexTMjugador AlexTMjugador added the enhancement New feature or request label Jul 14, 2022
@AlexTMjugador AlexTMjugador changed the title Feat.req. Remove possible unused codebook entries Remove possible unused codebook entries Jul 14, 2022
@AlexTMjugador AlexTMjugador added the hacktoberfest Issues you can help with for Hacktoberfest! label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Issues you can help with for Hacktoberfest!
Development

No branches or pull requests

2 participants