Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Create Military Families and Spouses page #154

Open
rickr opened this issue Jun 14, 2017 · 16 comments
Open

Create Military Families and Spouses page #154

rickr opened this issue Jun 14, 2017 · 16 comments

Comments

@rickr
Copy link
Contributor

rickr commented Jun 14, 2017

No description provided.

@rickr rickr added this to the Complete More Information Section milestone Jun 14, 2017
@hollomancer
Copy link
Member

@RobKriner, I believe we had a design for this already...

@hollomancer
Copy link
Member

desktop-military-families-design-spec

@alexspence
Copy link
Contributor

I've actually already done alot of the work for this page, as I was using it as the original homepage. components are in scenes/home/families.

If no one else picks it up I can probably tackle it in a few days.

@hollomancer
Copy link
Member

Once this page is up, I have some followup work to redirect Google Adwords to this page as a landing.

@kylemh kylemh modified the milestones: Complete More Information Section, Content Jun 30, 2017
@kylemh
Copy link
Member

kylemh commented Jul 10, 2017

I had a question on this. It looks very similar to the front-page. Do we have liberties to change up the banner image? This banner actually looks better suited for /families than it does the home page!

@hollomancer
Copy link
Member

@kylemh, yeah - do you have something in mind?

@kylemh
Copy link
Member

kylemh commented Jul 16, 2017

Looking at this again, I think we should just use the second image, as the banner image.

Have "The Facts" be devoid of an image.

@hollomancer
Copy link
Member

Depends how this looks on mobile. I like 'The Facts' being a two-column, and I do see your previous point about the banner being better suited for /families than the home page.

@kylemh
Copy link
Member

kylemh commented Jul 16, 2017

I'd say that we can keep this wireframe exactly as is, but only if we change the landing page's banner.

@hollomancer
Copy link
Member

Until we figure that out, I'm comfortable leaving it the way it is (or making it blank, like the /about page currently is right now), as an MVP.

@rickr rickr removed ready labels Aug 4, 2017
@mwagz
Copy link
Contributor

mwagz commented Sep 8, 2017

I'll pick this one up. If @rickr or @hollomancer want to assign it to me.

@kylemh
Copy link
Member

kylemh commented Sep 9, 2017

@mwagz to be clear - the wireframe is a great guideline, but do not use the same image header.

If you are able to replicate the curved hero bottom border, please try to cordon off that code for us to use on the landing page! 👍 also keep in mind that I'll be refactoring Nav/Header this weekend. Let me know if you implement any ideas so I don't reinvent the wheel. Consider using the

component as it is being used for the landing page within home.js

mwagz added a commit to mwagz/operationcode_frontend that referenced this issue Sep 10, 2017
This finalizes the Military Families and Spouses page as per Issue OperationCode#154.
This also adds the requirements for the clipping appearance as was
represented in the mockup.
@mwagz
Copy link
Contributor

mwagz commented Sep 10, 2017

@kylemh I didn't do anything crazy, but I did use as many pre-existing components as I was able to identify. For the curved hero bottom border, I came up with a solution that I'm not totally proud of, but it accomplishes the task.

There are 2 components in my PR, HeaderClipMaskLeft and HeaderClipMaskRight. These components are absolutely positioned to the first section on the page (the quote, in my case). I then set that section to be relatively positioned and include these new components in the Section. Reference is here.

These components could use some expanding upon. They're currently restricted to white and using props we could probably just use one component for both sides.

Outside of that stuff, I think I honored everything you outlined. I did take some liberties on mobile breakpoints.

mwagz added a commit to mwagz/operationcode_frontend that referenced this issue Oct 2, 2017
This finalizes the Military Families and Spouses page as per Issue OperationCode#154.
This also adds the requirements for the clipping appearance as was
represented in the mockup.
mwagz added a commit to mwagz/operationcode_frontend that referenced this issue Oct 2, 2017
This finalizes the Military Families and Spouses page as per Issue OperationCode#154.
This also adds the requirements for the clipping appearance as was
represented in the mockup.
@JennWeideman
Copy link
Collaborator

https://www.123rf.com this is a site full of free stock images. It might be nice if we could change up the images now and then

@kylemh
Copy link
Member

kylemh commented Jan 24, 2018

This page is nearly done. Somebody may feel free to hijack @mwagz's work to finish

apex-omontgomery pushed a commit to apex-omontgomery/operationcode_frontend that referenced this issue Apr 12, 2018
…mbers-db-seeds

Team Members created when seeding db
@kylemh
Copy link
Member

kylemh commented Oct 1, 2018

With this page not mapped out as an aspect of parity, it'll be subject to redesign before creating a new issue on the new repo. Leaving open until redesign is prepared.

chrisgalvan pushed a commit to chrisgalvan/operationcode_frontend that referenced this issue Oct 12, 2018
…hip-circle-page

Create /leadership_circle page
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants
@rickr @alexspence @hollomancer @kylemh @mwagz @JennWeideman and others